|
Post by zeak on Feb 8, 2019 0:00:19 GMT
For some reason it is ignoring that the condition of BOOLEAN4 is TRUE and runs the action of GOTO MACRO LINE | DOWN 3.
|
|
|
Post by Johnc on Feb 8, 2019 3:26:32 GMT
I sometimes got weird things out of MMM too. Just learned to go into the pencil editor and save it from there. And then save it again from the macro list. It usually would fix it! Also using the "diff" utility from DOS helps a lot in revision control of macro files and it can also show funny characters being added by the macro list!! When that happens, your macros r not going to run well!
|
|
|
Post by Steve on Feb 8, 2019 7:15:32 GMT
Zeak,
How are you declaring your boolean4 false?
Can you paste your macro?
1 | RUN ACTION | DEFINE BOOLEAN VARIABLE | %BOOLEAN4%::false 2 | IF | BOOLEAN VARIABLE | %BOOLEAN4% | IS FALSE | MESSAGE PROMPT | %boolean4% - Value of 4 is False::false::0 | ELSE | 3 | RUN ACTION | MESSAGE PROMPT | %boolean4% - Value True::True::0
This example will provide false for the condition and might help test the issue.
John is right to suggest editing using the pencil editor. Formatting issues in macro's often, and do, result in things like this.
|
|
|
Post by zeak on Feb 11, 2019 23:23:04 GMT
Hi Johnc, yeah I tried what you said but still get the same result.
Hi Steve, Here is the complete macro. Line 35 and 36 is where it is decided, Line 107 is where I'm getting the issue.
* | Clear_All_Variables
1 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER%::0
2 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER1%::0
3 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER2%::0
* | Clear_Function_Variables
4 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER3%::0
5 | RUN ACTION | DEFINE STRING VARIABLE | %STRING%::
6 | RUN ACTION | DEFINE STRING VARIABLE | %STRING1%::
7 | RUN ACTION | DEFINE STRING VARIABLE | %STRING2%::
8 | RUN ACTION | DEFINE STRING VARIABLE | %STRING3%::
9 | RUN ACTION | DEFINE BOOLEAN VARIABLE | %BOOLEAN%::FALSE
10 | RUN ACTION | DEFINE BOOLEAN VARIABLE | %BOOLEAN1%::FALSE
11 | RUN ACTION | DEFINE BOOLEAN VARIABLE | %BOOLEAN2%::FALSE
12 | RUN ACTION | DEFINE BOOLEAN VARIABLE | %BOOLEAN3%::FALSE
13 | RUN ACTION | DEFINE BOOLEAN VARIABLE | %BOOLEAN4%::FALSE
14 | RUN ACTION | DEFINE BOOLEAN VARIABLE | %BOOLEAN5%::FALSE
* | ## MAIN QUESTIONS ##
* | Question_Move
15 | RUN ACTION | INPUT BOX | Move Items Location?::Move Location?::PROMPT_YES_NO::STRING
16 | IF | STRING VARIABLE | %STRING% | IS | YES | DEFINE BOOLEAN VARIABLE | %BOOLEAN%::TRUE
17 | RUN ACTION | DEFINE STRING VARIABLE | %STRING%::
18 | IF | BOOLEAN VARIABLE | %BOOLEAN% | IS TRUE | GOTO MACRO LINE | Function_Move
19 | IF | BOOLEAN VARIABLE | %BOOLEAN% | IS FALSE | GOTO MACRO LINE | Question_Status
* | Question_Status
20 | RUN ACTION | INPUT BOX | Update Items Status?::Update Status?::PROMPT_YES_NO::STRING
21 | IF | STRING VARIABLE | %STRING% | IS | YES | DEFINE BOOLEAN VARIABLE | %BOOLEAN1%::TRUE
22 | RUN ACTION | DEFINE STRING VARIABLE | %STRING%::
23 | IF | BOOLEAN VARIABLE | %BOOLEAN1% | IS TRUE | GOTO MACRO LINE | Function_Status
24 | IF | BOOLEAN VARIABLE | %BOOLEAN1% | IS FALSE | GOTO MACRO LINE | Question_Expiry
* | Question_Expiry
25 | RUN ACTION | INPUT BOX | Update Items Expiry?::Update Expiry::PROMPT_YES_NO::STRING
26 | IF | STRING VARIABLE | %STRING% | IS | YES | DEFINE BOOLEAN VARIABLE | %BOOLEAN2%::TRUE
27 | RUN ACTION | DEFINE STRING VARIABLE | %STRING%::
28 | IF | BOOLEAN VARIABLE | %BOOLEAN2% | IS TRUE | GOTO MACRO LINE | Function_Expiry
29 | IF | BOOLEAN VARIABLE | %BOOLEAN2% | IS FALSE | GOTO MACRO LINE | Question_IssuesUnplanned
* | Question_IssuesUnplanned
30 | RUN ACTION | INPUT BOX | Issues Unplanned?::Issues Unplanned::PROMPT_YES_NO::STRING
31 | IF | STRING VARIABLE | %STRING% | IS | YES | DEFINE BOOLEAN VARIABLE | %BOOLEAN3%::TRUE
32 | RUN ACTION | DEFINE STRING VARIABLE | %STRING%::
33 | IF | BOOLEAN VARIABLE | %BOOLEAN3% | IS TRUE | GOTO MACRO LINE | Function_ISSUNP
34 | IF | BOOLEAN VARIABLE | %BOOLEAN3% | IS FALSE | GOTO MACRO LINE | Question_Continue
* | ## FUNCTION CONTROL ##
* | Function_Move
* | Function_Move_Site
35 | RUN ACTION | INPUT BOX | Changing Site?::SITE::PROMPT_YES_NO::STRING
36 | IF | STRING VARIABLE | %STRING% | IS | YES | DEFINE BOOLEAN VARIABLE | %BOOLEAN4%::TRUE
37 | RUN ACTION | DEFINE STRING VARIABLE | %STRING%::
38 | IF | BOOLEAN VARIABLE | %BOOLEAN4% | IS TRUE | GOTO MACRO LINE | Question_Site
39 | IF | BOOLEAN VARIABLE | %BOOLEAN4% | IS FALSE | GOTO MACRO LINE | Function_Move_Location
* | Function_Move_Location
40 | RUN ACTION | INPUT BOX | Changing Location?::LOCATION::PROMPT_YES_NO::STRING
41 | IF | STRING VARIABLE | %STRING% | IS | YES | DEFINE BOOLEAN VARIABLE | %BOOLEAN5%::TRUE
42 | RUN ACTION | DEFINE STRING VARIABLE | %STRING%::
43 | IF | BOOLEAN VARIABLE | %BOOLEAN5% | IS TRUE | GOTO MACRO LINE | Question_Location
44 | IF | BOOLEAN VARIABLE | %BOOLEAN5% | IS FALSE | GOTO MACRO LINE | Question_Continue
* | Function_Status
45 | RUN ACTION | INPUT BOX | Update Status to: 1.INAC 2.ISOLATE 3.OK::UPDATE STATUS::
46 | IF | INTEGER VARIABLE | %INTEGER3% | IS | 0 | GOTO MACRO LINE | Funcation_Status
47 | IF | INTEGER VARIABLE | %INTEGER3% | GREATER THAN | 3 | GOTO MACRO LINE | Funcation_Status
48 | IF | INTEGER VARIABLE | %INTEGER3% | IS | 1 | DEFINE STRING VARIABLE | %STRING1%::INAC
49 | IF | INTEGER VARIABLE | %INTEGER3% | IS | 2 | DEFINE STRING VARIABLE | %STRING1%::ISOLATE
50 | IF | INTEGER VARIABLE | %INTEGER3% | IS | 3 | DEFINE STRING VARIABLE | %STRING1%::OK
51 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER3%::0
52 | RUN ACTION | INPUT BOX | Is "%STRING1%" the correct Status?::STATUS CHECK::PROMPT_YES_NO::STRING3
53 | IF | STRING VARIABLE | %STRING3% | IS | NO | GOTO MACRO LINE | Function_Status
54 | RUN ACTION | DEFINE STRING VARIABLE | %STRING3%::
55 | RUN ACTION | GOTO MACRO LINE | QTY_CHANGE
* | Function_Expiry
56 | RUN ACTION | INPUT BOX | Please enter new expiry date (DD/MM/YYYY)::UPDATE EXPIRY::STRING1
57 | IF | STRING VARIABLE | %STRING1% | IS | | GOTO MACRO LINE | Function_Expiry
58 | RUN ACTION | INPUT BOX | Is "%STRING1%" the correct expiry?::EXPIRY CHECK::PROMPT_YES_NO::STRING3
59 | IF | STRING VARIABLE | %STRING3% | IS | NO | GOTO MACRO LINE | Function_Expiry
60 | RUN ACTION | DEFINE STRING VARIABLE | %STRING3%::
61 | RUN ACTION | GOTO MACRO LINE | QTY_CHANGE
* | Function_ISSUNP
62 | RUN ACTION | MESSAGE PROMPT | FUNCTION NOT AVAILABLE YET::::5
63 | RUN ACTION | GOTO MACRO LINE | Question_Continue
* | ## SECONDARY QUESTIONS ##
* | Question_Site
64 | RUN ACTION | INPUT BOX | New site please::SITE::STRING1
65 | IF | STRING VARIABLE | %STRING1% | IS | | GOTO MACRO LINE | Question_Site
66 | RUN ACTION | INPUT BOX | Is "%STRING1%" the correct site?::SITE CHECK::PROMPT_YES_NO::STRING3
67 | IF | STRING VARIABLE | %STRING3% | IS | NO | GOTO MACRO LINE | Question_Site
68 | RUN ACTION | DEFINE STRING VARIABLE | %STRING3%::
69 | RUN ACTION | GOTO MACRO LINE | Question_Location
* | Question_Location
70 | RUN ACTION | INPUT BOX | New location please::LOCATION::STRING2
71 | IF | STRING VARIABLE | %STRING2% | IS | | GOTO MACRO LINE | Question_Location
72 | RUN ACTION | INPUT BOX | Is "%STRING2%" the correct location?::LOCATION CHECK::PROMPT_YES_NO::STRING3
73 | IF | STRING VARIABLE | %STRING3% | IS | NO | GOTO MACRO LINE | Question_Location
74 | RUN ACTION | DEFINE STRING VARIABLE | %STRING3%::
75 | RUN ACTION | GOTO MACRO LINE | QTY_CHANGE
* | QTY_CHANGE
76 | RUN ACTION | INPUT BOX | Number of items to change/update?::QUANTITY TO CHANGE::INTEGER3
77 | IF | INTEGER VARIABLE | %INTEGER3% | IS | 0 | GOTO MACRO LINE | QTY_CHANGE
78 | RUN ACTION | INPUT BOX | Is "%INTEGER3%" the correct quantity?::QUANTITY CHECK::PROMPT_YES_NO::STRING3
79 | IF | STRING VARIABLE | %STRING3% | IS | NO | GOTO MACRO LINE | QTY_CHANGE
80 | RUN ACTION | DEFINE STRING VARIABLE | %STRING3%::
81 | RUN ACTION | GOTO MACRO LINE | Find_Search
* | ## FINDING BUTTONS ##
* | Find_Search
82 | IF | INTEGER VARIABLE | %INTEGER% | IS NOT | 0 | GOTO MACRO LINE | Find_Button
83 | RUN ACTION | MESSAGE PROMPT | Please click "OK" and then mouse over "Search" button.::SEARCH BUTTON::0
* | Find_Search_AfterPrompt
84 | IF | PIXEL RANGE | At Location [X:600 Y:130]::Size [W:500 H:25] | CHANGES::1::0::0 | DEFINE INTEGER VARIABLE | %INTEGER%::%MOUSE_X%
* | 89 | IF | INTEGER VARIABLE | %INTEGER% | IS NOT | 0 | MESSAGE PROMPT | %INTEGER%::MOUSE::1
* | 90 | %INTEGER% | 140 | 1 | Mouse Movement
* | 91 | RUN ACTION | INPUT BOX | Is this the correct Search Button location?::SEARCH BUTTON CHECK::PROMPT_YES_NO::STRING3
* | 92 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER%::0
* | 93 | IF | STRING VARIABLE | %STRING3% | IS | NO | GOTO MACRO LINE | Find_Search_AfterPrompt
85 | IF | INTEGER VARIABLE | %INTEGER% | IS | 0 | GOTO MACRO LINE | Find_Search_AfterPrompt
86 | IF | INTEGER VARIABLE | %INTEGER% | IS NOT | 0 | GOTO MACRO LINE | Find_Button
* | Find_Button
87 | IF | BOOLEAN VARIABLE | %BOOLEAN% | IS TRUE | GOTO MACRO LINE | Find_Batch
88 | IF | BOOLEAN VARIABLE | %BOOLEAN1% | IS TRUE | GOTO MACRO LINE | Find_Expiry
89 | IF | BOOLEAN VARIABLE | %BOOLEAN2% | IS TRUE | GOTO MACRO LINE | Find_Expiry
* | Find_Expiry
90 | IF | INTEGER VARIABLE | %INTEGER1% | IS NOT | 0 | GOTO MACRO LINE | Actions
91 | RUN ACTION | MESSAGE PROMPT | Please click "OK" and then mouse over "Update Expiry" button.::EXPIRY BUTTON::0
* | Find_Expiry_AfterPrompt
92 | IF | PIXEL RANGE | At Location [X:1100 Y:80]::Size [W:1000 H:30] | CHANGES::1::0::0 | DEFINE INTEGER VARIABLE | %INTEGER1%::%MOUSE_X%
93 | IF | INTEGER VARIABLE | %INTEGER1% | IS | 0 | GOTO MACRO LINE | Find_Expiry_AfterPrompt
94 | IF | INTEGER VARIABLE | %INTEGER1% | IS NOT | 0 | GOTO MACRO LINE | Actions
* | Find_Batch
95 | IF | INTEGER VARIABLE | %INTEGER2% | IS NOT | 0 | GOTO MACRO LINE | Actions
96 | RUN ACTION | MESSAGE PROMPT | Please click "OK" and then mouse over "Update Batch" button.::BATCH BUTTON::0
* | Find_Batch_AfterPrompt
97 | IF | PIXEL RANGE | At Location [X:1100 Y:80]::Size [W:1000 H:30] | CHANGES::1::0::0 | DEFINE INTEGER VARIABLE | %INTEGER2%::%MOUSE_X%
98 | IF | INTEGER VARIABLE | %INTEGER2% | IS | 0 | GOTO MACRO LINE | Find_Batch_AfterPrompt
99 | IF | INTEGER VARIABLE | %INTEGER2% | IS NOT | 0 | GOTO MACRO LINE | Actions
* | ## PERFORMING ACTIONS ##
* | Actions
100 | RUN ACTION | MESSAGE PROMPT | Button locations Registered, Click ok to continue.::BUTTONS REGISTERED::0
101 | IF | BOOLEAN VARIABLE | %BOOLEAN% | IS TRUE | GOTO MACRO LINE | Action_Move
102 | IF | BOOLEAN VARIABLE | %BOOLEAN1% | IS TRUE | GOTO MACRO LINE | Action_Status
103 | IF | BOOLEAN VARIABLE | %BOOLEAN2% | IS TRUE | GOTO MACRO LINE | Action_Expiry
* | Action_Move
104 | %INTEGER2% | 95 | 1000 | Left Click Down
105 | %INTEGER2% | 95 | 1000 | Left Click Release
106 | X | X | 750 | Keypress right
107 | IF | BOOLEAN VARIABLE | %BOOLEAN4% | IS FALSE | GOTO MACRO LINE | DOWN 3
108 | X | X | 750 | Keypress Ctrl+ | a
109 | X | X | 750 | Keypress %STRING1%
110 | X | X | 750 | Keypress tab
111 | X | X | 750 | Keypress %STRING2%
112 | X | X | 750 | Keypress enter
113 | X | X | 750 | Keypress enter
114 | X | X | 750 | Keypress Ctrl+ | enter
115 | X | X | 750 | Keypress Ctrl+ | enter
116 | %INTEGER% | 140 | 1000 | Left Click Down
117 | %INTEGER% | 140 | 1000 | Left Click Release
118 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER3%::-1
119 | IF | INTEGER VARIABLE | %INTEGER3% | IS | 0 | GOTO MACRO LINE | Question_Continue
120 | IF | INTEGER VARIABLE | %INTEGER3% | IS NOT | 0 | GOTO MACRO LINE | Action_Move
* | Action_Status
121 | %INTEGER1% | 95 | 1000 | Left Click Down
122 | %INTEGER1% | 95 | 1000 | Left Click Release
123 | X | X | 750 | Keypress right
124 | X | X | 750 | Keypress tab
125 | X | X | 750 | Keypress tab
126 | X | X | 750 | Keypress tab
127 | X | X | 750 | Keypress %STRING1%
128 | X | X | 750 | Keypress enter
129 | X | X | 750 | Keypress Ctrl+ | enter
130 | %INTEGER% | 140 | 1000 | Left Click Down
131 | %INTEGER% | 140 | 1000 | Left Click Release
132 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER3%::-1
133 | IF | INTEGER VARIABLE | %INTEGER3% | IS | 0 | GOTO MACRO LINE | Question_Continue
134 | IF | INTEGER VARIABLE | %INTEGER3% | IS NOT | 0 | GOTO MACRO LINE | Action_Status
* | Action_Expiry
135 | %INTEGER1% | 95 | 1000 | Left Click Down
136 | %INTEGER1% | 95 | 1000 | Left Click Release
137 | X | X | 750 | Keypress right
138 | X | X | 750 | Keypress Ctrl+ | a
139 | X | X | 750 | Keypress %STRING1%
140 | X | X | 750 | Keypress enter
141 | X | X | 750 | Keypress Ctrl+ | enter
142 | %INTEGER% | 140 | 1000 | Left Click Down
143 | %INTEGER% | 140 | 1000 | Left Click Release
144 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER3%::-1
145 | IF | INTEGER VARIABLE | %INTEGER3% | IS | 0 | GOTO MACRO LINE | Question_Continue
146 | IF | INTEGER VARIABLE | %INTEGER3% | IS NOT | 0 | GOTO MACRO LINE | Action_Expiry
* | Action_IssUnp
* | Question_Continue
147 | RUN ACTION | INPUT BOX | Do you wish to change something else?::CONTINUE?::PROMPT_YES_NO::STRING
148 | IF | STRING VARIABLE | %STRING% | IS | YES | GOTO MACRO LINE | Clear_Function_Variables
149 | IF | STRING VARIABLE | %STRING% | IS | NO | GOTO MACRO LINE | Exit
* | Exit
150 | RUN ACTION | EXIT
|
|
|
Post by zeak on Feb 13, 2019 0:53:37 GMT
Hey Steve,
It looks like this works correctly with the new version of MMM 7.1 but not with the PRO version I was using.
|
|
|
Post by Steve on Feb 13, 2019 7:28:52 GMT
Have you updated to the current PRO version? Were you using a BETA or custom build for your pro? BTW - nice macro too. Really sound use of the MMM logic - i like it
|
|
|
Post by zeak on Feb 13, 2019 22:38:17 GMT
Yea it was the BETA version you asked me to test that I had been using.
I haven't brought the PRO version yet, when my pay goes in I'll be buying it.
|
|