Loop using FOR | EACH | LINE IN

[dozer2014]

Just getting a feel for the program. Tried loading and reformatting 9 text reports created by Robocopy into a word processor. The 9 file names are present in a separate text file. The macro runs through the first file completely and successfully, but it doesn't repeat / go to the next file. FOR | NEXT is the last instruction in the macro. Can't figure out what I'm missing.

[Steve]

Hi,

Paste in your macro and we'll check out the FOR looping

[dozer2014]

1 | RUN ACTION | RUN VIA CMD /c | start C:\BATCH\DT1-FAVORITES-AND-MOVIES-DIRECTORIES.BAT
2 | RUN ACTION | WAIT SECONDS | 5
3 | FOR | EACH | LINE IN | C:\MYFILES\NOTEPAD\DT1-Reports.txt | DO
4 | IF | FILE | C:\OPEN-OFFICE\TEXT-DOCUMENTS\%line% | NOT EXIST | GOTO MACRO LINE | 31
5 | RUN ACTION | RUN VIA CMD /c | CD C:\
6 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
7 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\TEXT-DOCUMENTS\%line%"
8 | 820 | 420 | 2000 | Left Click Down
9 | 820 | 420 | 100 | Left Click Release
10 | 1478 | 542 | 2000 | Left Click Down
11 | 1478 | 542 | 100 | Left Click Release
12 | 1550 | 601 | 2000 | Left Click Down
13 | 1550 | 601 | 100 | Left Click Release
14 | 1489 | 631 | 2000 | Left Click Down
15 | 1489 | 631 | 100 | Left Click Release
16 | 13 | 30 | 2000 | Left Click Down
17 | 13 | 30 | 100 | Left Click Release
18 | 67 | 217 | 2000 | Left Click Down
19 | 67 | 217 | 100 | Left Click Release
20 | 512 | 427 | 2000 | Left Click Down
21 | 512 | 427 | 100 | Left Click Release
22 | 512 | 447 | 2000 | Left Click Down
23 | 512 | 447 | 100 | Left Click Release
24 | 633 | 557 | 2000 | Left Click Down
25 | 633 | 557 | 100 | Left Click Release
26 | 900 | 520 | 2000 | Left Click Down
27 | 900 | 520 | 100 | Left Click Release
28 | 1656 | 11 | 4000 | Left Click Down
29 | 1656 | 11 | 100 | Left Click Release
30 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\TEXT-DOCUMENTS\%line%
31 | FOR | NEXT

[Steve]

Hi,

Try using FOR EACH FILE rather than FOR EACH LINE.

FOR EACH FILE is going to loop through each file in a directory. I think essentially this is what you are trying to do. Rather than using FOR EACH LINE to loop through the names of files in text file, just use the directory containing the files.

The file names are assigned as %file%. Here are some other variables useful when using FOR looping:
- %I%: The count for the current iteration of the FOR loop
- %LINE%: Used in FOR EACH LINE loops, this variable holds the current text line in a file
- %FILE%: The full file path and name of the current FOR EACH FILE loop file
- %FILE.NAME%: The file name of the current FOR EACH FILE loop file
- %FILE.EXT%: The file extension of the current FOR EACH FILE loop file. For example this may be .txt or .rtf
- %FILE.PATHROOT%: The root of the file path for the current FOR EACH FILE loop file
- %FILE.PATH%: The file path without the file name of the current FOR EACH FILE loop file
- %FILE.ACCESSTIME%: The last file access time of the current FOR EACH FILE loop file
- %FILE.WRITETIME%: The last file write time of the current FOR EACH FILE loop file
- %FILE.CREATIONTIME%: the file creation time of the current FOR EACH FILE loop file

Try this addition to your code. I have used FOR EACH FILE.  You may need to tweak it a bit for you environment but I think it's the better way to go:

1 | RUN ACTION | RUN VIA CMD /c | start C:\BATCH\DT1-FAVORITES-AND-MOVIES-DIRECTORIES.BAT
2 | RUN ACTION | WAIT SECONDS | 5
4 | FOR | EACH | FILE IN | C:\OPEN-OFFICE\TEXT-DOCUMENTS\ | DO
4 | IF | FILE | %file% | NOT EXIST | GOTO MACRO LINE | 31
5 | RUN ACTION | RUN VIA CMD /c | CD C:\
6 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
7 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "%file%"
8 | 820 | 420 | 2000 | Left Click Down
9 | 820 | 420 | 100 | Left Click Release
10 | 1478 | 542 | 2000 | Left Click Down
11 | 1478 | 542 | 100 | Left Click Release
12 | 1550 | 601 | 2000 | Left Click Down
13 | 1550 | 601 | 100 | Left Click Release
14 | 1489 | 631 | 2000 | Left Click Down
15 | 1489 | 631 | 100 | Left Click Release
16 | 13 | 30 | 2000 | Left Click Down
17 | 13 | 30 | 100 | Left Click Release
18 | 67 | 217 | 2000 | Left Click Down
19 | 67 | 217 | 100 | Left Click Release
20 | 512 | 427 | 2000 | Left Click Down
21 | 512 | 427 | 100 | Left Click Release
22 | 512 | 447 | 2000 | Left Click Down
23 | 512 | 447 | 100 | Left Click Release
24 | 633 | 557 | 2000 | Left Click Down
25 | 633 | 557 | 100 | Left Click Release
26 | 900 | 520 | 2000 | Left Click Down
27 | 900 | 520 | 100 | Left Click Release
28 | 1656 | 11 | 4000 | Left Click Down
29 | 1656 | 11 | 100 | Left Click Release
30 | RUN ACTION | RUN VIA CMD /c | Del /q %file%
31 | FOR | NEXT

[dozer2014]

Got it........... Will do................

[dozer2014]

Interesting and puzzling. Changed the source (batch Robocopy report destination) so there were no other files in it except the .txt files that I wanted to convert and added a change so the new files got saved in the original source and overwrites the previously converted files when saved as before. Thought it may cause problems if it kept adding files to the directory it was reading from even though they weren't .txt file anymore. Also got rid of (4 | IF | FILE | %file% | NOT EXIST | GOTO MACRO LINE | 31) since it served no purpose with the new arrangement. (It was only reading files that did exist in that subdirectory). I also removed the Batch job from the beginning to run the batch and macro separately. Got essentially the same result though. Picks one file, converts it without a problem and then stops. Every time I run it, it picks one file, converts it and then stops. Still not looping. I originally had 9 separate routines in one macro, one for each file, that ran consecutively and did all 9 files. It works fine, but it's rather large and unnecessary if you're using a variable for the file names. The FOR statement should loop on it's own. Right? It doesn't need a counter or any additional coding as I understand it.

[Steve]

Sorry i'm not sure i get what you are saying.

Let me break down FOR looping in MMM.

The sample below:

1 | FOR | EACH | FILE IN | d:\macro\test | DO
2 | RUN ACTION | MESSAGE PROMPT | %file%::::0
3 | FOR | NEXT
A simple FOR LOOP. 'd:\macro\test' has 4 text files, test1.txt - through test4.txt.
Line 1 the for loop starts
Line 2 the first file, test1.txt, is the focused file for the for loop. %file% and all FOR file variables are allocated for this file. MESSAGE PROMPT displays 'd:\macro\test\test1.txt'.
Line 3 we loop back to line 2. This looping continues until all files are read in d:\macro\test. This FOR loop runs 4 times total, once for each file.

Any conditions I put between lines 1, the start of the for loop, and line 3, the end of the for loop, are executed during this for loop.

I can't say for sure why your macro is not working as expected. It looks fine, the syntax is correct.

Have you tried checking out the MMM event log? This shows a running log of the macro during playback. It's very useful to determine exactly what is happening with the macro.

[dozer2014]

Sorry, my explanation of the changes I made turned out longer than I intended. No......... I haven't tried checking out the event log. I'll continue "playing" with it and I'll get it working eventually. I like the program. I'm sure I'm just missing something. There has to be a reason for it. What you're saying is exactly how I expected it to work. Thanks

[dozer2014]

Needless to say, your little routine above worked fine once I put in the appropriate directory. Enabled event log and it seems it loads the next file before it ends. Attached the last few lines. Could the problem have something to do with the DOS commands?

11/07/2018 09:54:16.40 AM : Macro event: 31 | 1653 | 8 | 4984 | Left Click Down
11/07/2018 09:54:21.39 AM : Macro event: 32 | 1653 | 8 | 78 | Left Click Release
11/07/2018 09:54:21.49 AM : Macro condition: 33 | RUN ACTION | RUN VIA CMD /c | Del /q %file%
11/07/2018 09:54:21.50 AM : Macro condition - Condition TRUE
11/07/2018 09:54:21.52 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C Del /q C:\OPEN-OFFICE\DT1-A1-Compare.txt
11/07/2018 09:54:21.55 AM : Macro condition: 34 | FOR | NEXT
11/07/2018 09:54:21.57 AM : Macro condition - FOR Condition
11/07/2018 09:54:21.58 AM : Macro FOR 0 in do NEXT
11/07/2018 09:54:21.60 AM : Macro FOR - FILE(1): C:\OPEN-OFFICE\DT1-A1-Favorites.txt
11/07/2018 09:54:21.61 AM : Macro action - Running ACTION: GOTO MACRO LINE - Macro line(4)
11/07/2018 09:54:21.63 AM : Macro condition - Condition TRUE
11/07/2018 09:54:21.64 AM : Macro playback finished

[Steve]

It could be the del /q %file% from cmd.

Paste your full macro with the edits you have made and I will have another look.

Try adding a 'wait' to the del command. Something like this:
33 | RUN ACTION | RUN VIA CMD /c | ping -n 3 127.0.0.1>nul & Del /q "%file%"
The 'ping -n 3 127.0.0.1>nul' is a way to cause the command to wait for roughly 3 seconds. Combining this prior to the Del /q will allow for any timing issues at the release of the current %file% variable during the current loop iteration.

Give this one a go. Let me know how it goes dozer, keen to see this one through.

Cheers,
Steve.

[dozer2014]

I have the whole thing changed now. Trying a different approach. I've replaced the DOS commands and just trying to get 1 working without the FOR loop. I can give your suggestion a shot too but now I'm on a different tangent. I got rid of the (33 | RUN ACTION | RUN VIA CMD /c | Del /q "%file%") and replaced it with (33 | RUN ACTION | DELETE FILE | C:\OPEN-OFFICE\DT1-Favorites-Dozer-Mix.txt) which is working. The one I'm having problems with is (4 | RUN ACTION | RUN PROGRAM | C:\Program Files (x86)\OpenOffice 4\program\swriter.exe /E, C:\OPEN-OFFICE\DT1-Favorites-Dozer-Mix.txt). No matter what I do, it comes back and tells me it can't find the file that I want to load. I tried to do it this way initially, but I couldn't get it to load the file, with or without the quotes. Still can't get it to load. That's why I did it with (RUN VIA CMD). I tried sticking a wait in there too, but not the way you are doing it. I added a (3 | RUN ACTION | WAIT SECONDS | 2) right after the first FOR command.

Thanks Steve.

[dozer2014]

11/07/2018 05:51:54.33 PM : Macro list cleared
11/07/2018 05:51:54.34 PM : Macro quick launch: C:\MYFILES\MMM\DT1 Print Favorites Test.mmmacro
11/07/2018 05:51:54.36 PM : Starting macro playback
11/07/2018 05:51:54.38 PM : Macro condition: 1 | RUN ACTION | RUN VIA CMD /c | start C:\BATCH\DT1-FAVORITES-AND-MOVIES-DIRECTORIES.BAT
11/07/2018 05:51:54.39 PM : Macro condition - Condition TRUE
11/07/2018 05:51:54.41 PM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C start C:\BATCH\DT1-FAVORITES-AND-MOVIES-DIRECTORIES.BAT
11/07/2018 05:51:54.42 PM : Macro condition: 2 | RUN ACTION | WAIT SECONDS | 5
11/07/2018 05:51:54.44 PM : Macro condition - Condition TRUE
11/07/2018 05:51:54.45 PM : Macro action - Thread sleeping for 5 seconds
11/07/2018 05:51:59.41 PM : Macro condition: 3 | FOR | EACH | FILE IN | C:\OPEN-OFFICE\ | DO
11/07/2018 05:51:59.42 PM : Macro condition - FOR Condition
11/07/2018 05:51:59.44 PM : Macro FOR EACH FILE IN in C:\OPEN-OFFICE\ do DO
11/07/2018 05:51:59.45 PM : Macro condition - C:\OPEN-OFFICE\: Found
11/07/2018 05:51:59.47 PM : Macro condition - Condition TRUE
11/07/2018 05:51:59.48 PM : Macro condition: 5 | RUN ACTION | RUN VIA CMD /c | CD C:\
11/07/2018 05:51:59.50 PM : Macro condition - Condition TRUE
11/07/2018 05:51:59.52 PM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C CD C:\
11/07/2018 05:51:59.53 PM : Macro condition: 6 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
11/07/2018 05:51:59.55 PM : Macro condition - Condition TRUE
11/07/2018 05:51:59.56 PM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C CD C:\Program Files (x86)\OpenOffice 4\program\
11/07/2018 05:51:59.58 PM : Macro condition: 7 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "%file%"
11/07/2018 05:51:59.59 PM : Macro condition - Condition TRUE
11/07/2018 05:51:59.61 PM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C start swriter.exe /E, "C:\OPEN-OFFICE\DT1-A1-Compare.txt"
11/07/2018 05:51:59.62 PM : Macro event: 8 | 820 | 420 | 2000 | Left Click Down
11/07/2018 05:52:01.55 PM : Macro event: 9 | 820 | 420 | 100 | Left Click Release
11/07/2018 05:52:01.66 PM : Macro event: 10 | 1478 | 542 | 2000 | Left Click Down
11/07/2018 05:52:03.67 PM : Macro event: 11 | 1478 | 542 | 100 | Left Click Release
11/07/2018 05:52:03.78 PM : Macro event: 12 | 1550 | 601 | 2000 | Left Click Down
11/07/2018 05:52:05.80 PM : Macro event: 13 | 1550 | 601 | 100 | Left Click Release
11/07/2018 05:52:05.92 PM : Macro event: 14 | 1489 | 631 | 2000 | Left Click Down
11/07/2018 05:52:07.94 PM : Macro event: 15 | 1489 | 631 | 100 | Left Click Release
11/07/2018 05:52:08.06 PM : Macro event: 16 | 13 | 30 | 2000 | Left Click Down
11/07/2018 05:52:10.08 PM : Macro event: 17 | 13 | 30 | 100 | Left Click Release
11/07/2018 05:52:10.19 PM : Macro event: 18 | 67 | 217 | 2000 | Left Click Down
11/07/2018 05:52:12.20 PM : Macro event: 19 | 67 | 217 | 100 | Left Click Release
11/07/2018 05:52:12.33 PM : Macro event: 20 | 447 | 425 | 9327 | Left Click Down
11/07/2018 05:52:21.67 PM : Macro event: 21 | 447 | 426 | 94 | Left Click Release
11/07/2018 05:52:21.80 PM : Macro event: 22 | 438 | 451 | 1141 | Left Click Down
11/07/2018 05:52:22.95 PM : Macro event: 23 | 438 | 451 | 78 | Left Click Release
11/07/2018 05:52:23.05 PM : Macro event: 24 | 260 | 263 | 6906 | Left Click Down
11/07/2018 05:52:29.97 PM : Macro event: 25 | 260 | 263 | 78 | Left Click Release
11/07/2018 05:52:30.06 PM : Macro event: 26 | 260 | 263 | 391 | Left Click Down
11/07/2018 05:52:30.47 PM : Macro event: 27 | 260 | 263 | 62 | Left Click Release
11/07/2018 05:52:30.54 PM : Macro event: 28 | 640 | 560 | 12718 | Left Click Down
11/07/2018 05:52:43.28 PM : Macro event: 29 | 640 | 560 | 78 | Left Click Release
11/07/2018 05:52:43.37 PM : Macro event: 30 | 901 | 518 | 3246 | Left Click Down
11/07/2018 05:52:46.64 PM : Macro event: 31 | 901 | 518 | 78 | Left Click Release
11/07/2018 05:52:46.73 PM : Macro event: 32 | 1653 | 8 | 4984 | Left Click Down
11/07/2018 05:52:51.74 PM : Macro event: 33 | 1653 | 8 | 78 | Left Click Release
11/07/2018 05:52:51.84 PM : Macro condition: 34 | RUN ACTION | RUN VIA CMD /c | ping -n 3 127.0.0.1>nul & Del /q %file%
11/07/2018 05:52:51.85 PM : Macro condition - Condition TRUE
11/07/2018 05:52:51.87 PM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C ping -n 3 127.0.0.1>nul & Del /q C:\OPEN-OFFICE\DT1-A1-Compare.txt
11/07/2018 05:52:51.88 PM : Macro condition: 35 | FOR | NEXT
11/07/2018 05:52:51.90 PM : Macro condition - FOR Condition
11/07/2018 05:52:51.92 PM : Macro FOR 0 in do NEXT
11/07/2018 05:52:51.93 PM : Macro FOR - FILE(1): C:\OPEN-OFFICE\DT1-A1-Favorites.txt
11/07/2018 05:52:51.95 PM : Macro action - Running ACTION: GOTO MACRO LINE - Macro line(4)
11/07/2018 05:52:51.96 PM : Macro condition - Condition TRUE
11/07/2018 05:52:51.98 PM : Macro playback finished

[Steve]

Good stuff looks like we worked through it in the end.

RUN PROGRAM is failing because it's not accepting the program arguments (RUN PROGRAM | C:\Program Files (x86)\OpenOffice 4\program\swriter.exe /E, C:\OPEN-OFFICE\DT1-Favorites-Dozer-Mix.txt).
MMM is treating that one line as 'the program' and not 'the program + program arguments'. I hope that makes sense. So with the arguments it will always return your error 'can not find the file'. This is not very efficient. I will look to change this for the next update. RUN PROGRAM should be able to accept arguments.

Thanks. Good luck with your script

[dozer2014]

You go with what works.........................🤞

[dozer2014]

Did a simple test. Thought you might be interested in the result. Speaks for itself.

11/08/2018 11:35:08.88 AM : Macro quick launch: C:\MYFILES\MMM\DT1 Print Favorites Test.mmmacro
11/08/2018 11:35:08.90 AM : Macro loop enabled
11/08/2018 11:35:08.92 AM : Starting macro playback
11/08/2018 11:35:08.93 AM : Macro condition: 1 | RUN ACTION | RUN VIA CMD /c | start C:\BATCH\DT1-FAVORITES-AND-MOVIES-DIRECTORIES.BAT
11/08/2018 11:35:08.95 AM : Macro condition - Condition TRUE
11/08/2018 11:35:08.96 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C start C:\BATCH\DT1-FAVORITES-AND-MOVIES-DIRECTORIES.BAT
11/08/2018 11:35:08.98 AM : Macro condition: 2 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER%::0
11/08/2018 11:35:08.99 AM : Macro condition - Condition TRUE
11/08/2018 11:35:09.01 AM : Macro action - Variable (%INTEGER% = 0)
11/08/2018 11:35:09.03 AM : Macro condition: 3 | RUN ACTION | WAIT SECONDS | 5
11/08/2018 11:35:09.04 AM : Macro condition - Condition TRUE
11/08/2018 11:35:09.06 AM : Macro action - Thread sleeping for 5 seconds
11/08/2018 11:35:13.95 AM : Macro condition: 4 | RUN ACTION | RUN VIA CMD /c | CD C:\
11/08/2018 11:35:13.96 AM : Macro condition - Condition TRUE
11/08/2018 11:35:13.98 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C CD C:\
11/08/2018 11:35:13.99 AM : Macro condition: 5 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
11/08/2018 11:35:14.01 AM : Macro condition - Condition TRUE
11/08/2018 11:35:14.02 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C CD C:\Program Files (x86)\OpenOffice 4\program\
11/08/2018 11:35:14.04 AM : Macro condition: 6 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\TEXT-DOCUMENTS\DT1-A1-Favorites.txt"
11/08/2018 11:35:14.06 AM : Macro condition - Condition TRUE
11/08/2018 11:35:14.07 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C start swriter.exe /E, "C:\OPEN-OFFICE\TEXT-DOCUMENTS\DT1-A1-Favorites.txt"
11/08/2018 11:35:14.09 AM : Macro event: 7 | 820 | 420 | 2000 | Left Click Down
11/08/2018 11:35:16.10 AM : Macro event: 8 | 820 | 420 | 100 | Left Click Release
11/08/2018 11:35:16.24 AM : Macro event: 9 | 1478 | 542 | 2000 | Left Click Down
11/08/2018 11:35:18.26 AM : Macro event: 10 | 1478 | 542 | 100 | Left Click Release
11/08/2018 11:35:18.37 AM : Macro event: 11 | 1550 | 601 | 2000 | Left Click Down
11/08/2018 11:35:20.40 AM : Macro event: 12 | 1550 | 601 | 100 | Left Click Release
11/08/2018 11:35:20.51 AM : Macro event: 13 | 1489 | 631 | 2000 | Left Click Down
11/08/2018 11:35:22.52 AM : Macro event: 14 | 1489 | 631 | 100 | Left Click Release
11/08/2018 11:35:22.63 AM : Macro event: 15 | 13 | 30 | 2000 | Left Click Down
11/08/2018 11:35:24.66 AM : Macro event: 16 | 13 | 30 | 100 | Left Click Release
11/08/2018 11:35:24.76 AM : Macro event: 17 | 67 | 217 | 2000 | Left Click Down
11/08/2018 11:35:26.79 AM : Macro event: 18 | 67 | 217 | 100 | Left Click Release
11/08/2018 11:35:26.90 AM : Macro event: 19 | 512 | 427 | 2000 | Left Click Down
11/08/2018 11:35:28.91 AM : Macro event: 20 | 512 | 427 | 100 | Left Click Release
11/08/2018 11:35:29.04 AM : Macro event: 21 | 512 | 447 | 2000 | Left Click Down
11/08/2018 11:35:31.06 AM : Macro event: 22 | 512 | 447 | 100 | Left Click Release
11/08/2018 11:35:31.16 AM : Macro event: 23 | 633 | 557 | 2000 | Left Click Down
11/08/2018 11:35:33.20 AM : Macro event: 24 | 633 | 557 | 100 | Left Click Release
11/08/2018 11:35:33.30 AM : Macro event: 25 | 900 | 520 | 2000 | Left Click Down
11/08/2018 11:35:35.33 AM : Macro event: 26 | 900 | 520 | 100 | Left Click Release
11/08/2018 11:35:35.43 AM : Macro event: 27 | 1656 | 11 | 4000 | Left Click Down
11/08/2018 11:35:39.47 AM : Macro event: 28 | 1656 | 11 | 100 | Left Click Release
11/08/2018 11:35:39.58 AM : Macro condition: 29 | RUN ACTION | DEFINE INTEGER VARIABLE | %INTEGER%::+1
11/08/2018 11:35:39.59 AM : Macro condition - Condition TRUE
11/08/2018 11:35:39.61 AM : Macro action - Variable (%INTEGER% = +1)
11/08/2018 11:35:39.63 AM : Macro condition: 30 | IF | INTEGER VARIABLE | %INTEGER% | < | 3 | GOTO MACRO LINE | 3
11/08/2018 11:35:39.64 AM : Macro condition - 1<3
11/08/2018 11:35:39.66 AM : Macro condition - Condition TRUE
11/08/2018 11:35:39.67 AM : Macro action - Running ACTION: GOTO MACRO LINE - Macro line(3)
11/08/2018 11:35:39.69 AM : Macro playback finished

[dozer2014]

Following up.

All 283 lines of the macro are running fine all the way through as is.

1. I replaced the RUN VIA CMD /c with DELETE FILE. It blows up after the 7th file and just stops dead. Attached the last part of the report.

11/11/2018 08:33:44.52 AM : Macro condition: 204 | RUN ACTION | RUN VIA CMD /c | CD C:\
11/11/2018 08:33:44.54 AM : Macro condition - Condition TRUE
11/11/2018 08:33:44.56 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C CD C:\
11/11/2018 08:33:44.57 AM : Macro condition: 205 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
11/11/2018 08:33:44.59 AM : Macro condition - Condition TRUE
11/11/2018 08:33:44.60 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C CD C:\Program Files (x86)\OpenOffice 4\program\
11/11/2018 08:33:44.62 AM : Macro condition: 206 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Susie-Mix.txt"
11/11/2018 08:33:44.63 AM : Macro condition - Condition TRUE
11/11/2018 08:33:44.65 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Susie-Mix.txt"
11/11/2018 08:33:44.67 AM : Macro event: 207 | 820 | 420 | 2000 | Left Click Down
11/11/2018 08:33:46.63 AM : Macro event: 208 | 820 | 420 | 100 | Left Click Release
11/11/2018 08:33:46.76 AM : Macro event: 209 | 1478 | 542 | 2000 | Left Click Down
11/11/2018 08:33:48.77 AM : Macro event: 210 | 1478 | 542 | 100 | Left Click Release
11/11/2018 08:33:48.88 AM : Macro event: 211 | 1550 | 601 | 2000 | Left Click Down
11/11/2018 08:33:50.91 AM : Macro event: 212 | 1550 | 601 | 100 | Left Click Release
11/11/2018 08:33:51.02 AM : Macro event: 213 | 1489 | 631 | 2000 | Left Click Down
11/11/2018 08:33:53.04 AM : Macro event: 214 | 1489 | 631 | 100 | Left Click Release
11/11/2018 08:33:53.15 AM : Macro event: 215 | 13 | 30 | 2000 | Left Click Down
11/11/2018 08:33:55.16 AM : Macro event: 216 | 13 | 30 | 100 | Left Click Release
11/11/2018 08:33:55.27 AM : Macro event: 217 | 67 | 217 | 2000 | Left Click Down
11/11/2018 08:33:57.31 AM : Macro event: 218 | 67 | 217 | 100 | Left Click Release
11/11/2018 08:33:57.41 AM : Macro event: 219 | 432 | 538 | 2000 | Left Click Down
11/11/2018 08:33:59.43 AM : Macro event: 220 | 432 | 538 | 100 | Left Click Release
11/11/2018 08:33:59.55 AM : Macro event: 221 | 432 | 559 | 2000 | Left Click Down
11/11/2018 08:34:01.57 AM : Macro event: 222 | 432 | 559 | 100 | Left Click Release
11/11/2018 08:34:01.70 AM : Macro event: 223 | 667 | 668 | 2000 | Left Click Down
11/11/2018 08:34:03.71 AM : Macro event: 224 | 667 | 668 | 100 | Left Click Release
11/11/2018 08:34:03.82 AM : Macro event: 225 | 900 | 520 | 2000 | Left Click Down
11/11/2018 08:34:05.83 AM : Macro event: 226 | 900 | 520 | 100 | Left Click Release
11/11/2018 08:34:05.95 AM : Macro event: 227 | 1656 | 11 | 4000 | Left Click Down
11/11/2018 08:34:09.97 AM : Macro event: 228 | 1656 | 11 | 100 | Left Click Release
11/11/2018 08:34:10.08 AM : Macro condition: 229 | RUN ACTION | DELETE FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Susie-Mix.txt
11/11/2018 08:34:10.09 AM : Macro condition - Condition TRUE
11/11/2018 08:34:10.11 AM : Macro action - Delete File (C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Susie-Mix.txt)
11/11/2018 08:34:10.13 AM : Macro condition: 230 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Susie-Mix.txt | NOT EXIST | GOTO MACRO LINE | 257
11/11/2018 08:34:10.14 AM : Macro condition - C:\OPEN-OFFICE\DOCUMENTS\DT1-FAVORITES-SUSIE-MIX.TXT: Not Found
11/11/2018 08:34:10.16 AM : Macro condition - Condition TRUE
11/11/2018 08:34:10.17 AM : Macro action - Running ACTION: GOTO MACRO LINE - Macro line(257)
11/11/2018 08:34:10.19 AM : Macro playback finished

2. Made a small 3 line integer loop that did a "keypress enter" 23 times. Stand alone, it worked fine. When I plugged it into MY macro and the program came to it, it executed 1 keypress enter
and stopped dead.

Steve,
If you would like me to attach the entire macro, I'll do it. It's just the same thing you already have here 1 time for each of the 9 files.

[Steve]

Ok lets nut out these issues...

1. Lets replace DELETE FILE with RUN VIA CMD:
33 | RUN ACTION | RUN VIA CMD /c | ping -n 3 127.0.0.1>nul & Del /q "%file%"

Deleting %file%, the loop focused file, during a running loop is most likely the cause of your issue. Adding the wait is going to allow the release of the %file% variable within the loop prior to deleting the file.

2. The error with your simple loop could be a side effect of the bad FOR loop, bad syntax, or something else. Without checking it out it's hard to say. Paste your code in for this loop and I will check it out. Or just paste the whole thing in and point out where you are looping.

Paste the code in, use the 'insert code' tool above.

[dozer2014]

The list at the very beginning of this post is the way each file is coded for the loop. As it is right now, .................. I guess it would be easier to just show you rather than try to explain it. Here's the whole thing WORKING!

1 | RUN ACTION | RUN VIA CMD /c | start C:\BATCH\DT1-FAVORITES-AND-MOVIES-DIRECTORIES.BAT
2 | RUN ACTION | WAIT SECONDS | 5
3 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-A1-Favorites.txt | NOT EXIST | GOTO MACRO LINE | 30
4 | RUN ACTION | RUN VIA CMD /c | CD C:\
5 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
6 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-A1-Favorites.txt"
7 | 820 | 420 | 2000 | Left Click Down
8 | 820 | 420 | 100 | Left Click Release
9 | 1478 | 542 | 2000 | Left Click Down
10 | 1478 | 542 | 100 | Left Click Release
11 | 1550 | 601 | 2000 | Left Click Down
12 | 1550 | 601 | 100 | Left Click Release
13 | 1489 | 631 | 2000 | Left Click Down
14 | 1489 | 631 | 100 | Left Click Release
15 | 13 | 30 | 2000 | Left Click Down
16 | 13 | 30 | 100 | Left Click Release
17 | 67 | 217 | 2000 | Left Click Down
18 | 67 | 217 | 100 | Left Click Release
19 | 432 | 538 | 2000 | Left Click Down
20 | 432 | 538 | 100 | Left Click Release
21 | 432 | 559 | 2000 | Left Click Down
22 | 432 | 559 | 100 | Left Click Release
23 | 667 | 668 | 2000 | Left Click Down
24 | 667 | 668 | 100 | Left Click Release
25 | 900 | 520 | 2000 | Left Click Down
26 | 900 | 520 | 100 | Left Click Release
27 | 1656 | 11 | 4000 | Left Click Down
28 | 1656 | 11 | 100 | Left Click Release
29 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\DOCUMENTS\DT1-A1-Favorites.txt
30 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-A1-Compare.txt | NOT EXIST | GOTO MACRO LINE | 95
31 | RUN ACTION | RUN VIA CMD /c | CD C:\
32 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
33 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-A1-Compare.txt"
34 | 820 | 420 | 2000 | Left Click Down
35 | 820 | 420 | 100 | Left Click Release
36 | 1478 | 542 | 2000 | Left Click Down
37 | 1478 | 542 | 100 | Left Click Release
38 | 1550 | 601 | 2000 | Left Click Down
39 | 1550 | 601 | 100 | Left Click Release
40 | 1489 | 631 | 2000 | Left Click Down
41 | 1489 | 631 | 100 | Left Click Release
42 | 344 | 233 | 2000 | Left Click Down
43 | 344 | 233 | 100 | Left Click Release
44 | 48 | 30 | 2000 | Left Click Down
45 | 48 | 30 | 100 | Left Click Release
46 | 119 | 338 | 2000 | Left Click Down
47 | 119 | 338 | 100 | Left Click Release
48 | 119 | 338 | 2000 | Keypress 1
49 | 119 | 338 | 1000 | Keypress 0
50 | 119 | 338 | 1000 | Keypress 0
51 | 1046 | 534 | 2000 | Left Click Down
52 | 1046 | 534 | 100 | Left Click Release
53 | 1058 | 765 | 2000 | Left Click Down
54 | 1058 | 765 | 100 | Left Click Release
55 | 1058 | 765 | 500 | Keypress home
56 | 1058 | 765 | 500 | Keypress down
57 | 1058 | 765 | 500 | Keypress enter
58 | 1058 | 765 | 500 | Keypress enter
59 | 1058 | 765 | 500 | Keypress enter
60 | 1058 | 765 | 500 | Keypress enter
61 | 1058 | 765 | 500 | Keypress enter
62 | 1058 | 765 | 500 | Keypress enter
63 | 1058 | 765 | 500 | Keypress enter
64 | 1058 | 765 | 500 | Keypress enter
65 | 1058 | 765 | 500 | Keypress enter
66 | 1058 | 765 | 500 | Keypress enter
67 | 1058 | 765 | 500 | Keypress enter
68 | 1058 | 765 | 500 | Keypress enter
69 | 1058 | 765 | 500 | Keypress enter
70 | 1058 | 765 | 500 | Keypress enter
71 | 1058 | 765 | 500 | Keypress enter
72 | 1058 | 765 | 500 | Keypress enter
73 | 1058 | 765 | 500 | Keypress enter
74 | 1058 | 765 | 500 | Keypress enter
75 | 1058 | 765 | 500 | Keypress enter
76 | 1058 | 765 | 500 | Keypress enter
77 | 1058 | 765 | 500 | Keypress enter
78 | 1058 | 765 | 500 | Keypress enter
79 | 1058 | 765 | 3000 | Keypress Ctrl+ | home
80 | 13 | 30 | 2000 | Left Click Down
81 | 13 | 30 | 100 | Left Click Release
82 | 67 | 217 | 2000 | Left Click Down
83 | 67 | 217 | 100 | Left Click Release
84 | 432 | 538 | 2000 | Left Click Down
85 | 432 | 538 | 100 | Left Click Release
86 | 432 | 559 | 2000 | Left Click Down
87 | 432 | 559 | 100 | Left Click Release
88 | 667 | 668 | 2000 | Left Click Down
89 | 667 | 668 | 100 | Left Click Release
90 | 900 | 520 | 2000 | Left Click Down
91 | 900 | 520 | 100 | Left Click Release
92 | 1656 | 11 | 4000 | Left Click Down
93 | 1656 | 11 | 100 | Left Click Release
94 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\DOCUMENTS\DT1-A1-Compare.txt
95 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Dozer-Mix.txt | NOT EXIST | GOTO MACRO LINE | 122
96 | RUN ACTION | RUN VIA CMD /c | CD C:\
97 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
98 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Dozer-Mix.txt"
99 | 820 | 420 | 2000 | Left Click Down
100 | 820 | 420 | 100 | Left Click Release
101 | 1478 | 542 | 2000 | Left Click Down
102 | 1478 | 542 | 100 | Left Click Release
103 | 1550 | 601 | 2000 | Left Click Down
104 | 1550 | 601 | 100 | Left Click Release
105 | 1489 | 631 | 2000 | Left Click Down
106 | 1489 | 631 | 100 | Left Click Release
107 | 13 | 30 | 2000 | Left Click Down
108 | 13 | 30 | 100 | Left Click Release
109 | 67 | 217 | 2000 | Left Click Down
110 | 67 | 217 | 100 | Left Click Release
111 | 432 | 538 | 2000 | Left Click Down
112 | 432 | 538 | 100 | Left Click Release
113 | 432 | 559 | 2000 | Left Click Down
114 | 432 | 559 | 100 | Left Click Release
115 | 667 | 668 | 2000 | Left Click Down
116 | 667 | 668 | 100 | Left Click Release
117 | 900 | 520 | 2000 | Left Click Down
118 | 900 | 520 | 100 | Left Click Release
119 | 1656 | 11 | 4000 | Left Click Down
120 | 1656 | 11 | 100 | Left Click Release
121 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Dozer-Mix.txt
122 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Lauren-Mix.txt | NOT EXIST | GOTO MACRO LINE | 149
123 | RUN ACTION | RUN VIA CMD /c | CD C:\
124 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
125 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Lauren-Mix.txt"
126 | 820 | 420 | 2000 | Left Click Down
127 | 820 | 420 | 100 | Left Click Release
128 | 1478 | 542 | 2000 | Left Click Down
129 | 1478 | 542 | 100 | Left Click Release
130 | 1550 | 601 | 2000 | Left Click Down
131 | 1550 | 601 | 100 | Left Click Release
132 | 1489 | 631 | 2000 | Left Click Down
133 | 1489 | 631 | 100 | Left Click Release
134 | 13 | 30 | 2000 | Left Click Down
135 | 13 | 30 | 100 | Left Click Release
136 | 67 | 217 | 2000 | Left Click Down
137 | 67 | 217 | 100 | Left Click Release
138 | 432 | 538 | 2000 | Left Click Down
139 | 432 | 538 | 100 | Left Click Release
140 | 432 | 559 | 2000 | Left Click Down
141 | 432 | 559 | 100 | Left Click Release
142 | 667 | 668 | 2000 | Left Click Down
143 | 667 | 668 | 100 | Left Click Release
144 | 900 | 520 | 2000 | Left Click Down
145 | 900 | 520 | 100 | Left Click Release
146 | 1656 | 11 | 4000 | Left Click Down
147 | 1656 | 11 | 100 | Left Click Release
148 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Lauren-Mix.txt
149 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Rebel-Mix.txt | NOT EXIST | GOTO MACRO LINE | 176
150 | RUN ACTION | RUN VIA CMD /c | CD C:\
151 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
152 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Rebel-Mix.txt"
153 | 820 | 420 | 2000 | Left Click Down
154 | 820 | 420 | 100 | Left Click Release
155 | 1478 | 542 | 2000 | Left Click Down
156 | 1478 | 542 | 100 | Left Click Release
157 | 1550 | 601 | 2000 | Left Click Down
158 | 1550 | 601 | 100 | Left Click Release
159 | 1489 | 631 | 2000 | Left Click Down
160 | 1489 | 631 | 109 | Left Click Release
161 | 13 | 30 | 2000 | Left Click Down
162 | 13 | 30 | 100 | Left Click Release
163 | 67 | 217 | 2000 | Left Click Down
164 | 67 | 217 | 100 | Left Click Release
165 | 432 | 538 | 2000 | Left Click Down
166 | 432 | 538 | 100 | Left Click Release
167 | 432 | 559 | 2000 | Left Click Down
168 | 432 | 559 | 100 | Left Click Release
169 | 667 | 668 | 2000 | Left Click Down
170 | 667 | 668 | 100 | Left Click Release
171 | 900 | 520 | 2000 | Left Click Down
172 | 900 | 520 | 100 | Left Click Release
173 | 1656 | 11 | 4000 | Left Click Down
174 | 1656 | 11 | 100 | Left Click Release
175 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Rebel-Mix.txt
176 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Flora-Mix.txt | NOT EXIST | GOTO MACRO LINE | 203
177 | RUN ACTION | RUN VIA CMD /c | CD C:\
178 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
179 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Flora-Mix.txt"
180 | 820 | 420 | 2000 | Left Click Down
181 | 820 | 420 | 100 | Left Click Release
182 | 1478 | 542 | 2000 | Left Click Down
183 | 1478 | 542 | 100 | Left Click Release
184 | 1550 | 601 | 2000 | Left Click Down
185 | 1550 | 601 | 100 | Left Click Release
186 | 1489 | 631 | 2000 | Left Click Down
187 | 1489 | 631 | 100 | Left Click Release
188 | 13 | 30 | 2000 | Left Click Down
189 | 13 | 30 | 100 | Left Click Release
190 | 67 | 217 | 2000 | Left Click Down
191 | 67 | 217 | 100 | Left Click Release
192 | 432 | 538 | 2000 | Left Click Down
193 | 432 | 538 | 100 | Left Click Release
194 | 432 | 559 | 2000 | Left Click Down
195 | 432 | 559 | 100 | Left Click Release
196 | 667 | 668 | 2000 | Left Click Down
197 | 667 | 668 | 100 | Left Click Release
198 | 900 | 520 | 2000 | Left Click Down
199 | 900 | 520 | 100 | Left Click Release
200 | 1656 | 11 | 4000 | Left Click Down
201 | 1656 | 11 | 100 | Left Click Release
202 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Flora-Mix.txt
203 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Susie-Mix.txt | NOT EXIST | GOTO MACRO LINE | 230
204 | RUN ACTION | RUN VIA CMD /c | CD C:\
205 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
206 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Susie-Mix.txt"
207 | 820 | 420 | 2000 | Left Click Down
208 | 820 | 420 | 100 | Left Click Release
209 | 1478 | 542 | 2000 | Left Click Down
210 | 1478 | 542 | 100 | Left Click Release
211 | 1550 | 601 | 2000 | Left Click Down
212 | 1550 | 601 | 100 | Left Click Release
213 | 1489 | 631 | 2000 | Left Click Down
214 | 1489 | 631 | 100 | Left Click Release
215 | 13 | 30 | 2000 | Left Click Down
216 | 13 | 30 | 100 | Left Click Release
217 | 67 | 217 | 2000 | Left Click Down
218 | 67 | 217 | 100 | Left Click Release
219 | 432 | 538 | 2000 | Left Click Down
220 | 432 | 538 | 100 | Left Click Release
221 | 432 | 559 | 2000 | Left Click Down
222 | 432 | 559 | 100 | Left Click Release
223 | 667 | 668 | 2000 | Left Click Down
224 | 667 | 668 | 100 | Left Click Release
225 | 900 | 520 | 2000 | Left Click Down
226 | 900 | 520 | 100 | Left Click Release
227 | 1656 | 11 | 4000 | Left Click Down
228 | 1656 | 11 | 100 | Left Click Release
229 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Susie-Mix.txt
230 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Susie-Mix.txt | NOT EXIST | GOTO MACRO LINE | 257
231 | RUN ACTION | RUN VIA CMD /c | CD C:\
232 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
233 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-Movies.txt"
234 | 820 | 420 | 2000 | Left Click Down
235 | 820 | 420 | 100 | Left Click Release
236 | 1478 | 542 | 2000 | Left Click Down
237 | 1478 | 542 | 100 | Left Click Release
238 | 1550 | 601 | 2000 | Left Click Down
239 | 1550 | 601 | 100 | Left Click Release
240 | 1489 | 631 | 2000 | Left Click Down
241 | 1489 | 631 | 100 | Left Click Release
242 | 13 | 30 | 2000 | Left Click Down
243 | 13 | 30 | 100 | Left Click Release
244 | 67 | 217 | 2000 | Left Click Down
245 | 67 | 217 | 100 | Left Click Release
246 | 432 | 538 | 2000 | Left Click Down
247 | 432 | 538 | 100 | Left Click Release
248 | 432 | 559 | 2000 | Left Click Down
249 | 432 | 559 | 100 | Left Click Release
250 | 667 | 668 | 2000 | Left Click Down
251 | 667 | 668 | 100 | Left Click Release
252 | 900 | 520 | 2000 | Left Click Down
253 | 900 | 520 | 100 | Left Click Release
254 | 1656 | 11 | 4000 | Left Click Down
255 | 1656 | 11 | 100 | Left Click Release
256 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\DOCUMENTS\DT1-Movies.txt
257 | IF | FILE | C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Xtra.txt | NOT EXIST | EXIT
258 | RUN ACTION | RUN VIA CMD /c | CD C:\
259 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
260 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Xtra.txt"
261 | 820 | 420 | 2000 | Left Click Down
262 | 820 | 420 | 100 | Left Click Release
263 | 1478 | 542 | 2000 | Left Click Down
264 | 1478 | 542 | 100 | Left Click Release
265 | 1550 | 601 | 2000 | Left Click Down
266 | 1550 | 601 | 100 | Left Click Release
267 | 1489 | 631 | 2000 | Left Click Down
268 | 1489 | 631 | 100 | Left Click Release
269 | 13 | 30 | 2000 | Left Click Down
270 | 13 | 30 | 100 | Left Click Release
271 | 67 | 217 | 2000 | Left Click Down
272 | 67 | 217 | 100 | Left Click Release
273 | 432 | 538 | 2000 | Left Click Down
274 | 432 | 538 | 100 | Left Click Release
275 | 432 | 559 | 2000 | Left Click Down
276 | 432 | 559 | 100 | Left Click Release
277 | 667 | 668 | 2000 | Left Click Down
278 | 667 | 668 | 100 | Left Click Release
279 | 900 | 520 | 2000 | Left Click Down
280 | 900 | 520 | 100 | Left Click Release
281 | 1656 | 11 | 4000 | Left Click Down
282 | 1656 | 11 | 100 | Left Click Release
283 | RUN ACTION | RUN VIA CMD /c | Del /q C:\OPEN-OFFICE\DOCUMENTS\DT1-Favorites-Xtra.txt

If you go to the lines that have | NOT EXIST | GOTO MACRO LINE | whatever you can brake it down into it's individual parts. One for each file. They are all about 31 line long except for 1.

There are currently NO loops. If you go back to line 57, this is where I plugged in the integer loop. I just simply removed all the keypress enters and inserted the loop in it's place. Like I said, the little routine worked fine stand alone.

1 | FOR | I | = | 1 TO 23 | NEXT
2 | 1058 | 765 | 500 | Keypress enter
3 | FOR | NEXT

Let me just try the RUN ACTION statement you have above without the loop, see what it does, and then I'll add the loop back in again.

As for 2, I agree 100%, but I can't find the bad syntax or what I'm doing wrong.

[dozer2014]

Steve,
Just so you know.....
I'm over 65. I have 2 associate degrees. One in Electronics and one in Computer Science. Beyond that, I'm self taught. I have repaired large Mainframes back in the 70's and 80's and written diagnostics in DEC machine language. After PC's came out, I installed and maintained networks. Been out of it since my business partner died about 10 years ago.

Not trying to "blow my horn". I just want you to know that I'm not a novice. :-))
There are definitely things I still don't know and am not up to speed on..................

[dozer2014]

Here we go. Attached a list of the files generated by Robocopy.

New File 17707 DT1-A1-Compare.txt
New File 5394 DT1-A1-Favorites.txt
New File 2540 DT1-Favorites-Dozer-Mix.txt
New File 2560 DT1-Favorites-Flora-Mix.txt
New File 2525 DT1-Favorites-Lauren-Mix.txt
New File 2467 DT1-Favorites-Rebel-Mix.txt
New File 2504 DT1-Favorites-Susie-Mix.txt
New File 51 DT1-Favorites-Xtra.txt
New File 7473 DT1-Movies.txt

These are all the files in the referenced directory. All they are is a list of songs in that directory (playlists).

Below is the Event Log.

11/14/2018 10:22:35.86 AM : Macro list cleared
11/14/2018 10:22:44.94 AM : Loading macro: DT1 Print Favorites Test.mmmacro
11/14/2018 10:22:52.80 AM : Macro re-listed
11/14/2018 10:22:58.72 AM : Macro saved: DT1 Print Favorites Test.mmmacro
11/14/2018 10:23:18.72 AM : Macro list cleared
11/14/2018 10:23:18.74 AM : Macro quick launch: C:\MYFILES\MMM\DT1 Print Favorites Test.mmmacro
11/14/2018 10:23:18.75 AM : Starting macro playback
11/14/2018 10:23:18.77 AM : Macro condition: 1 | FOR | EACH | FILE IN | C:\OPEN-OFFICE\ | DO
11/14/2018 10:23:18.78 AM : Macro condition - FOR Condition
11/14/2018 10:23:18.80 AM : Macro FOR EACH FILE IN in C:\OPEN-OFFICE\ do DO
11/14/2018 10:23:18.81 AM : Macro condition - C:\OPEN-OFFICE\: Found
11/14/2018 10:23:18.83 AM : Macro condition - Condition TRUE
11/14/2018 10:23:18.85 AM : Macro condition: 2 | RUN ACTION | RUN VIA CMD /c | CD C:\
11/14/2018 10:23:18.86 AM : Macro condition - Condition TRUE
11/14/2018 10:23:18.88 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C CD C:\
11/14/2018 10:23:18.89 AM : Macro condition: 3 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
11/14/2018 10:23:18.91 AM : Macro condition - Condition TRUE
11/14/2018 10:23:18.92 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C CD C:\Program Files (x86)\OpenOffice 4\program\
11/14/2018 10:23:18.94 AM : Macro condition: 4 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "%file%"
11/14/2018 10:23:18.96 AM : Macro condition - Condition TRUE
11/14/2018 10:23:18.97 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C start swriter.exe /E, "C:\OPEN-OFFICE\DT1-A1-Favorites.txt"
11/14/2018 10:23:18.99 AM : Macro event: 5 | 820 | 420 | 2000 | Left Click Down
11/14/2018 10:23:20.92 AM : Macro event: 6 | 820 | 420 | 100 | Left Click Release
11/14/2018 10:23:21.03 AM : Macro event: 7 | 1478 | 542 | 2000 | Left Click Down
11/14/2018 10:23:23.05 AM : Macro event: 8 | 1478 | 542 | 100 | Left Click Release
11/14/2018 10:23:23.17 AM : Macro event: 9 | 1550 | 601 | 2000 | Left Click Down
11/14/2018 10:23:25.19 AM : Macro event: 10 | 1550 | 601 | 100 | Left Click Release
11/14/2018 10:23:25.31 AM : Macro event: 11 | 1489 | 631 | 2000 | Left Click Down
11/14/2018 10:23:27.33 AM : Macro event: 12 | 1489 | 631 | 100 | Left Click Release
11/14/2018 10:23:27.44 AM : Macro event: 13 | 13 | 30 | 2000 | Left Click Down
11/14/2018 10:23:29.45 AM : Macro event: 14 | 13 | 30 | 100 | Left Click Release
11/14/2018 10:23:29.58 AM : Macro event: 15 | 67 | 217 | 2000 | Left Click Down
11/14/2018 10:23:31.60 AM : Macro event: 16 | 67 | 217 | 100 | Left Click Release
11/14/2018 10:23:31.72 AM : Macro event: 17 | 432 | 538 | 2000 | Left Click Down
11/14/2018 10:23:33.74 AM : Macro event: 18 | 432 | 538 | 100 | Left Click Release
11/14/2018 10:23:33.84 AM : Macro event: 19 | 432 | 559 | 2000 | Left Click Down
11/14/2018 10:23:35.88 AM : Macro event: 20 | 432 | 559 | 100 | Left Click Release
11/14/2018 10:23:35.99 AM : Macro event: 21 | 667 | 668 | 2000 | Left Click Down
11/14/2018 10:23:38.00 AM : Macro event: 22 | 667 | 668 | 100 | Left Click Release
11/14/2018 10:23:38.13 AM : Macro event: 23 | 900 | 520 | 2000 | Left Click Down
11/14/2018 10:23:40.14 AM : Macro event: 24 | 900 | 520 | 100 | Left Click Release
11/14/2018 10:23:40.25 AM : Macro event: 25 | 1656 | 11 | 4000 | Left Click Down
11/14/2018 10:23:44.27 AM : Macro event: 26 | 1656 | 11 | 100 | Left Click Release
11/14/2018 10:23:44.38 AM : Macro condition: 27 | RUN ACTION | RUN VIA CMD /c | ping -n 3 127.0.0.1>nul & Del /q "%file%"
11/14/2018 10:23:44.39 AM : Macro condition - Condition TRUE
11/14/2018 10:23:44.41 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C ping -n 3 127.0.0.1>nul & Del /q "C:\OPEN-OFFICE\DT1-A1-Favorites.txt"
11/14/2018 10:23:44.44 AM : Macro condition: 28 | FOR | NEXT
11/14/2018 10:23:44.45 AM : Macro condition - FOR Condition
11/14/2018 10:23:44.47 AM : Macro FOR 0 in do NEXT
11/14/2018 10:23:44.48 AM : Macro FOR - FILE(1): C:\OPEN-OFFICE\DT1-A1-Favorites.txt
11/14/2018 10:23:44.50 AM : Macro action - Running ACTION: GOTO MACRO LINE - Macro line(2)
11/14/2018 10:23:44.52 AM : Macro condition - Condition TRUE
11/14/2018 10:23:44.53 AM : Macro playback finished

Where is says GOTO MACRO LINE - Macro line(2) That's what it should be doing, but it's not. ??
The one that it did came out fine.

[Steve]

Ok i think i see what could be the issue.

Are you breaking out of the FOR LOOP with your GOTO?

If your in a current FOR LOOP, lets say loop 5 of 10 for example, in MMM you can't use GOTO to go back before the loop.

For example:1 | RUN ACTION | WAIT SECONDS | 2
2 | FOR | EACH | LINE IN | E:\Macro\OUTPUT\output.txt | DO
3 | RUN ACTION | MESSAGE PROMPT | %line%::::0
4 | RUN ACTION | GOTO MACRO LINE | 1
5 | FOR | NEXT
- This will fail as the loop has not ended.

This will work:

1 | RUN ACTION | WAIT SECONDS | 2
2 | FOR | EACH | LINE IN | E:\Macro\OUTPUT\output.txt | DO
3 | RUN ACTION | MESSAGE PROMPT | %line%::::0
4 | RUN ACTION | EXIT FOR
5 | FOR | NEXT
6 | RUN ACTION | GOTO MACRO LINE | 1

The FOR LOOP must end or be EXITED prior to GOTO.

[dozer2014]

Very good point! Except that the GOTO I have in there is only for testing the existence of the file. If it's not there, skip it.............. I removed that in the FOR loop. Here's a copy of the code itself.

1 | FOR | EACH | FILE IN | C:\OPEN-OFFICE\ | DO
2 | RUN ACTION | RUN VIA CMD /c | CD C:\
3 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
4 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "%file%"
5 | 820 | 420 | 2000 | Left Click Down
6 | 820 | 420 | 100 | Left Click Release
7 | 1478 | 542 | 2000 | Left Click Down
8 | 1478 | 542 | 100 | Left Click Release
9 | 1550 | 601 | 2000 | Left Click Down
10 | 1550 | 601 | 100 | Left Click Release
11 | 1489 | 631 | 2000 | Left Click Down
12 | 1489 | 631 | 100 | Left Click Release
13 | 13 | 30 | 2000 | Left Click Down
14 | 13 | 30 | 100 | Left Click Release
15 | 67 | 217 | 2000 | Left Click Down
16 | 67 | 217 | 100 | Left Click Release
17 | 258 | 293 | 2000 | Left Click Down
18 | 258 | 293 | 100 | Left Click Release
19 | 258 | 293 | 500 | Left Click Down
20 | 258 | 293 | 100 | Left Click Release
21 | 432 | 538 | 2000 | Left Click Down
22 | 432 | 538 | 100 | Left Click Release
23 | 432 | 559 | 2000 | Left Click Down
24 | 432 | 559 | 100 | Left Click Release
25 | 667 | 668 | 2000 | Left Click Down
26 | 667 | 668 | 100 | Left Click Release
27 | 900 | 520 | 2000 | Left Click Down
28 | 900 | 520 | 100 | Left Click Release
29 | 1656 | 11 | 4000 | Left Click Down
30 | 1656 | 11 | 100 | Left Click Release
31 | RUN ACTION | RUN VIA CMD /c | ping -n 3 127.0.0.1>nul & Del /q "%file%"
32 | FOR | NEXT

I think what you're looking at is generated by the FOR | NEXT command. All I'm doing is loading a file, editing it and saving it in a different format then deleting the .txt file.

I'm hoping that whatever it is, it's my glitch and not yours. :-)

[Steve]

The fact that you are not looping through any of the files is odd.

I did notice an issue with your macro. Not the syntax but some of the outcome you expect might not be happening.

2 | RUN ACTION | RUN VIA CMD /c | CD C:\
3 | RUN ACTION | RUN VIA CMD /c | CD C:\Program Files (x86)\OpenOffice 4\program\
4 | RUN ACTION | RUN VIA CMD /c | start swriter.exe /E, "%file%"
Lines 2,3, and 4. Each command shell carries it's own environment. The three shells you open are all unique and do not carry your directory traversal.
Shell one performs CD C:\ then closes.
Shell two CD C:\Program Files (x86)\OpenOffice 4\program\ then closes.
Shell three start swriter.exe /E, "%file%" then closes.

Shell three does not carry the directory change from shell one and two. You are going to have to explicitly define the full command path for swriter.exe. "C:\Program Files (x86)\OpenOffice 4\program\swriter.exe" for this to be effective.

Other than that I don't see why your macro is not looping.

Does this work:
1 | FOR | EACH | FILE IN | C:\OPEN-OFFICE\ | DO
2 | RUN ACTION | MESSAGE PROMPT | %file%::%I%::4
3 | FOR | NEXT
This three line macro is going to test your for loop. It will prompt the file name::the file count number::and close the prompt after 4 seconds.

If this works, prompting for each file, then we know the problem is somewhere in the middle; the problem if this fails has to be syntax related in the main block of the FOR LOOP.

[dozer2014]

You're right about that first issue. What can I say........... I initially tried it all in one string with RUN PROGRAM. (We discussed that before). I also tried it with the /k on the first 2 and all that did was leave me with a whole bunch of open windows. I know it doesn't look right, but it works........... I'll try it again with just 1 shell. May have been just a typo. Couldn't find the file that way either. I'll see what happens with the message prompt.

[dozer2014]

Your 3 line FOR atatement worked fine. Just like the one I made to do 23 "ENTERS". Until I put it in my program, then it quit working. As for the other issue, I changed it and put it all in one. Didn't load the program and the mouse just ran all over the desktop. It didn't loop either.

11/16/2018 08:12:04.22 AM : Macro list cleared
11/16/2018 08:12:04.23 AM : Macro quick launch: C:\MYFILES\MMM\DT1 Print Favorites Test.mmmacro
11/16/2018 08:12:04.25 AM : Starting macro playback
11/16/2018 08:12:04.26 AM : Macro condition: 1 | FOR | EACH | FILE IN | C:\OPEN-OFFICE\ | DO
11/16/2018 08:12:04.28 AM : Macro condition - FOR Condition
11/16/2018 08:12:04.29 AM : Macro FOR EACH FILE IN in C:\OPEN-OFFICE\ do DO
11/16/2018 08:12:04.31 AM : Macro condition - C:\OPEN-OFFICE\: Found
11/16/2018 08:12:04.32 AM : Macro condition - Condition TRUE
11/16/2018 08:12:04.34 AM : Macro condition: 3 | RUN ACTION | RUN VIA CMD /c | start "C:\Program Files (x86)\OpenOffice 4\program\swriter.exe" /E, "%file%"
11/16/2018 08:12:04.36 AM : Macro condition - Condition TRUE
11/16/2018 08:12:04.37 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C start "C:\Program Files (x86)\OpenOffice 4\program\swriter.exe" /E, "C:\OPEN-OFFICE\DT1-Favorites-Flora-Mix.txt"
11/16/2018 08:12:04.39 AM : Macro event: 5 | 820 | 420 | 2000 | Left Click Down
11/16/2018 08:12:06.28 AM : Macro event: 6 | 820 | 420 | 100 | Left Click Release
11/16/2018 08:12:06.40 AM : Macro event: 7 | 1478 | 542 | 2000 | Left Click Down
11/16/2018 08:12:08.42 AM : Macro event: 8 | 1478 | 542 | 100 | Left Click Release
11/16/2018 08:12:08.53 AM : Macro event: 9 | 1550 | 601 | 2000 | Left Click Down
11/16/2018 08:12:10.54 AM : Macro event: 10 | 1550 | 601 | 100 | Left Click Release
11/16/2018 08:12:10.65 AM : Macro event: 11 | 1489 | 631 | 2000 | Left Click Down
11/16/2018 08:12:12.67 AM : Macro event: 12 | 1489 | 631 | 100 | Left Click Release
11/16/2018 08:12:12.78 AM : Macro event: 13 | 13 | 30 | 2000 | Left Click Down
11/16/2018 08:12:14.79 AM : Macro event: 14 | 13 | 30 | 100 | Left Click Release
11/16/2018 08:12:14.90 AM : Macro event: 15 | 67 | 217 | 2000 | Left Click Down
11/16/2018 08:12:16.93 AM : Macro event: 16 | 67 | 217 | 100 | Left Click Release
11/16/2018 08:12:17.04 AM : Macro event: 17 | 258 | 293 | 2000 | Left Click Down
11/16/2018 08:12:19.06 AM : Macro event: 18 | 258 | 293 | 100 | Left Click Release
11/16/2018 08:12:19.17 AM : Macro event: 19 | 258 | 293 | 500 | Left Click Down
11/16/2018 08:12:19.68 AM : Macro event: 20 | 258 | 293 | 100 | Left Click Release
11/16/2018 08:12:19.79 AM : Macro event: 21 | 432 | 538 | 2000 | Left Click Down
11/16/2018 08:12:21.81 AM : Macro event: 22 | 432 | 538 | 100 | Left Click Release
11/16/2018 08:12:21.92 AM : Macro event: 23 | 432 | 559 | 2000 | Left Click Down
11/16/2018 08:12:23.93 AM : Macro event: 24 | 432 | 559 | 100 | Left Click Release
11/16/2018 08:12:24.04 AM : Macro event: 25 | 667 | 668 | 2000 | Left Click Down
11/16/2018 08:12:26.06 AM : Macro event: 26 | 667 | 668 | 100 | Left Click Release
11/16/2018 08:12:26.17 AM : Macro event: 27 | 900 | 520 | 2000 | Left Click Down
11/16/2018 08:12:28.18 AM : Macro event: 28 | 900 | 520 | 100 | Left Click Release
11/16/2018 08:12:28.29 AM : Macro event: 29 | 1656 | 11 | 4000 | Left Click Down
11/16/2018 08:12:32.31 AM : Macro event: 30 | 1656 | 11 | 100 | Left Click Release
11/16/2018 08:12:32.43 AM : Macro condition: 31 | RUN ACTION | RUN VIA CMD /c | ping -n 3 127.0.0.1>nul & Del /q "%file%"
11/16/2018 08:12:32.45 AM : Macro condition - Condition TRUE
11/16/2018 08:12:32.46 AM : Macro action - Running ACTION: RUN VIA CMD /c - CMD /C ping -n 3 127.0.0.1>nul & Del /q "C:\OPEN-OFFICE\DT1-Favorites-Flora-Mix.txt"
11/16/2018 08:12:32.48 AM : Macro condition: 32 | FOR | NEXT
11/16/2018 08:12:32.49 AM : Macro condition - FOR Condition
11/16/2018 08:12:32.51 AM : Macro FOR 0 in do NEXT
11/16/2018 08:12:32.53 AM : Macro FOR - FILE(1): C:\OPEN-OFFICE\DT1-Favorites-Lauren-Mix.txt
11/16/2018 08:12:32.54 AM : Macro action - Running ACTION: GOTO MACRO LINE - Macro line(2)
11/16/2018 08:12:32.56 AM : Macro condition - Condition TRUE
11/16/2018 08:12:32.57 AM : Macro playback finished

[dozer2014]

Didn't help a whole lot, but one thing I discovered is the quote at the end of the .exe needed to encompass the /E", I ran the string directly from the DOS prompt. The file loaded into NotePad. I couldn't get swriter.exe to run from there for anything. If I do what I did with your program, it works (Change to root, then change to C:\Program Files (x86)\OpenOffice 4\program\, then run swriter. I know............ It SHOULDN'T work that way. Beats the hell out of me.................. I was just trying to find something that worked and that did. I tried to do it the way it was "supposed to" work initially............

[dozer2014]

If I saw this problem about 20 years ago I would say the it needs to get added to the PATH statement in the AUTOEXEC.BAT file. Got me. I'm out of ideas. Still like your program......... Most of the routines I've written to this point work fine...........

[dozer2014]

Checked the format of the START command. I don't remember where I got the /E. An older version of START maybe. Anyhow, this works with just 1 instruction.

2 | RUN ACTION | RUN VIA CMD /c | START "" "C:\Program Files (x86)\OpenOffice 4\program\swriter.exe" "%file%"

Fixed that, but it still doesn't loop...................

[Steve]

Hmmm

Ok lets break it down again...

1. The FOR LOOP syntax it's self is working. We tested a basic loop with your directory and a message box displayed the file names as they should be.
2. We nutted out the command shell path. swriter.exe is being called as it should.
3. The main body, the 'guts' of the macro, your mouse clicks seem ok.
4. The cmd /c DEL %file% line....
- We touched on last week. Deleting the %file%, the current file in the FOR LOOP iteration, is not really a good idea. I'm not sure if we tested without this.
- Perhaps we try and remove this and delete the files retrospectively; after the macro has completed the FOR LOOP. Maybe using a command shell call again DEL *.* in the dir or something similar.

What do you think....We are going to get this if it kills me....lol

[dozer2014]

After I realized the difference with the start statement I went around all my batch jobs and fixed them even if they were working. Which they were.
Hey.......... I'm game...............
I considered that, but if you don't delete the .txt files it's going to just run indefinately isn't it? Right now I have it set up so the "processed" files get put into a different directory.
What the heck.......... I'll give it a shot.........