Help with for loop

[ghirotre]

Hi,

Thanks for you program. it is super
I have some problem with for loop.
I have a text file with multiple command :
 lightonbathroom
 lightonbedroom

in my macro:
7 | FOR | EACH | LINE IN | C:\Domotico\comandoalle.txt | DO

8 | FOR | EACH | LINE IN | C:\Domotico\macro\alle\app\%LINE%.mmmacro | RUN

9 | FOR | NEXT

because there is 2 for i have a problem.
I have tried with this:
7 | FOR | EACH | LINE IN | C:\Domotico\comandoalle.txt | DO

8 | RUN ACTION | RUN PROGRAM | C:\Domotico\macro\alle\app\%LINE%.mmmacro

9 | FOR | NEXT
and it is ok but it is slow, bacause open an other mmmacro.exe . An other problem with this solution it is the macro go foward and don't wait the other macro finish.

Another problem that i have:
with a control string from a file don't Always check correct.
My macro (it is same above):
1 | RUN ACTION | INPUT FROM FILE | STRING::REFRESH::C:\Domotico\casa.txt

2 | IF | STRING VARIABLE | %STRING% | CONTAINS | start | CONTINUE

3 | IF | STRING VARIABLE | %STRING% | CONTAINS | start alle | GOTO MACRO LINE | 5

4 | IF | STRING VARIABLE | %STRING% | CONTAINS | start fede | GOTO MACRO LINE | 13

I post the entire macro and a possibile command macro:
loop:
1 | RUN ACTION | INPUT FROM FILE | STRING::REFRESH::C:\Domotico\casa.txt

2 | IF | STRING VARIABLE | %STRING% | CONTAINS | start | CONTINUE

3 | IF | STRING VARIABLE | %STRING% | CONTAINS | start alle | GOTO MACRO LINE | 5

4 | IF | STRING VARIABLE | %STRING% | CONTAINS | start fede | GOTO MACRO LINE | 13

5 | RUN ACTION | OUTPUT TO FILE | C:\Domotico\casa.txt::OVERWRITE::wait

6 | RUN ACTION | DEFINE STRING VARIABLE | %STRING%::wait

7 | FOR | EACH | LINE IN | C:\Domotico\comandoalle.txt | DO

8 | RUN ACTION | RUN PROGRAM | C:\Domotico\macro\alle\app\%LINE%.mmmacro

9 | FOR | NEXT

10 | RUN ACTION | WAIT SECONDS | 10

11 | RUN ACTION | OUTPUT TO FILE | C:\Domotico\comandoalle.txt::OVERWRITE::wait

12 | RUN ACTION | INPUT FROM FILE | STRING1::NO_REFRESH::C:\Domotico\risghalle.txt

13 | RUN ACTION | RUN VIA CMD /C | C:\Programmi\Cast\Cast.exe -device "Google Home Sala" "Google Home Ballatoio"  -text %STRING1%

14 | RUN ACTION | OUTPUT TO FILE | C:\Domotico\risghalle.txt::OVERWRITE::

15 | RUN ACTION | GOTO MACRO LINE | 1insert code here
command:
1 | IF | WINDOW TITLE | Domotic 3.0 | EXIST | SELECT WINDOW BY NAME | Domotic 3.0 | ELSE | 1 | RUN ACTION |  |  |  | RUN PROGRAM | C:\Domotico\Alle.bat

2 | IF | PROCESS NAME | Fede | NOT EXIST | CONTINUE

3 | IF | PROCESS NAME | Alle | NOT EXIST | CONTINUE

4 | IF | PIXEL COLOR | Color [R=255, G=226, B=45]::At Location [X:170 Y:145] | IS THE SAME | OUTPUT TO FILE | C:\Domotico\risghalle.txt::APPEND::luce della sala già accesa,

5 | IF | PIXEL COLOR | Color [R=47, G=47, B=47]::At Location [X:170 Y:145] | IS THE SAME | OUTPUT TO FILE | C:\Domotico\risghalle.txt::APPEND::Ho acceso la luce della sala,

6 | IF | PIXEL COLOR | Color [R=47, G=47, B=47]::At Location [X:170 Y:145] | IS THE SAME | DEFINE STRING VARIABLE | %STRING3%::Left Click Down

7 | IF | PIXEL COLOR | Color [R=47, G=47, B=47]::At Location [X:170 Y:145] | IS THE SAME | DEFINE STRING VARIABLE | %STRING4%::Left Click Release

8 | 355 | 255 | 2 | %STRING3%

9 | 355 | 255 | 2 | %STRING4%

10 | RUN ACTION | WAIT MILLISECONDS | 300

11 | RUN ACTION | DEFINE STRING VARIABLE | %STRING3%::

12 | RUN ACTION | DEFINE STRING VARIABLE | %STRING4%::

13 | IF | PIXEL COLOR | Color [R=255, G=226, B=45]::At Location [X:170 Y:145] | IS NOT THE SAME | OUTPUT TO FILE | C:\Domotico\risghalle.txt::APPEND::Problema, chiama AlessandroI need to use %STRING3% and %STRING4%, because if i use FOR EACH LINE *.MMMACRO RUN, i can't use the GOTO action, and with IF condition it isn't possible to use Left Click Down or Left Click Release

Thanks

[Steve]

Apr 14, 2019 20:07:33 GMT ghirotre said:

I have tried with this:
7 | FOR | EACH | LINE IN | C:\Domotico\comandoalle.txt | DO
8 | RUN ACTION | RUN PROGRAM | C:\Domotico\macro\alle\app\%LINE%.mmmacro
9 | FOR | NEXT
and it is ok but it is slow, bacause open an other mmmacro.exe . An other problem with this solution it is the macro go foward and don't wait the other macro finish.

Another problem that i have:
with a control string from a file don't Always check correct.
My macro (it is same above):
1 | RUN ACTION | INPUT FROM FILE | STRING::REFRESH::C:\Domotico\casa.txt
2 | IF | STRING VARIABLE | %STRING% | CONTAINS | start | CONTINUE
3 | IF | STRING VARIABLE | %STRING% | CONTAINS | start alle | GOTO MACRO LINE | 5
4 | IF | STRING VARIABLE | %STRING% | CONTAINS | start fede | GOTO MACRO LINE | 13

Hi,

Ok so a lot of things going on here.

Firstly to kick this off - the first problem "the macro goes forward and don't wait..."

Have you considered using the main macro Window Title as the condition catch? (https://www.turnssoft.com/conditions.html#windowtitle) and (https://www.turnssoft.com/conditions.html#settitle)
Something like this from the main macro:
1 | RUN ACTION | SET TITLE | start

Something like this from the secondary macro:
2 | IF | WINDOW TITLE | start | EXIST | CONTINUE

Secondly, with the string from file - have you considered using file status instead?
Something like this from the main macro:
4 | RUN ACTION | OUTPUT TO FILE | D:\Macro\OUTPUT\output.txt::OVERWRITE::start

Something like this from the secondary macro:
5 | IF | FILE | D:\Macro\OUTPUT\output.txt | FILE CONTAINS STRING | start | CONTINUE
or perhaps
6 | IF | FILE | D:\Macro\OUTPUT\output.txt | EXIST | CONTINUE