MMM crashed after running few minutes

[kampberg]

Hello Steve,

I have a 53-lines macro and it's running perfectly as my expected, however, after running few minutes, the MMM will be force closed. I didn't have this problem for my other macros, I suspect there's bad logic in my macro that caused the OS drained all memory to get it closed but I couldn't catch the bug, can you help me?

BTW, I love this application, it's just Brilliant!

1 | RUN ACTION |  |  |  | INPUT BOX | Enter Integer3 ::Integer3::INTEGER3

2 | RUN ACTION |  |  |  | INPUT BOX | Enter Integer1::Integer1::INTEGER1

3 | RUN ACTION |  |  |  | INPUT BOX | Enter Integer2 ::Integer2::INTEGER2

4 | RUN ACTION |  |  |  | DEFINE INTEGER VARIABLE | %INTEGER4%::0

5 | 166 | 168 | 0 | Left Click Down

6 | 166 | 168 | 0 | Left Click Release

7 | IF | INTEGER VARIABLE | %INTEGER4% | GREATER THAN EQUAL TO | 10 | GOTO MACRO LINE | 9

8 | RUN ACTION |  |  |  | GOTO MACRO LINE | 13

9 | 869 | 843 | 500 | Left Click Down

10 | 869 | 843 | 0 | Left Click Release

11 | 869 | 843 | 0 | Keypress backspace

12 | RUN ACTION |  |  |  | DEFINE INTEGER VARIABLE | %INTEGER4%::0

13 | 1109 | 842 | 500 | Left Click Down

14 | 1109 | 842 | 150 | Left Click Release

15 | RUN ACTION |  |  |  | DEFINE INTEGER VARIABLE | %INTEGER4%::+1

16 | 1516 | 1192 | 50 | Left Click Down

17 | 1516 | 1192 | 50 | Left Click Release

18 | RUN ACTION |  |  |  | WAIT SECONDS | 0.5

19 | IF | PIXEL COLOR | Color [R=4, G=17, B=46]::At Location [X:61 Y:1113] | IS NOT THE SAME | GOTO MACRO LINE | 21

20 | RUN ACTION |  |  |  | GOTO MACRO LINE | 19

21 | IF | PIXEL COLOR | Color [R=127, G=254, B=225]::At Location [X:769 Y:410] | IS THE SAME | GOTO MACRO LINE | 24

22 | IF | PIXEL COLOR | Color [R=203, G=207, B=219]::At Location [X:1110 Y:789] | IS THE SAME | GOTO MACRO LINE | 5

23 | RUN ACTION |  |  |  | GOTO MACRO LINE | 21

24 | 1931 | 983 | 50 | Left Click Down

25 | 1931 | 983 | 50 | Left Click Release

25 | IF | PIXEL COLOR | Color [R=22, G=87, B=231]::At Location [X:1191 Y:636] | IS NOT THE SAME | GOTO MACRO LINE | 24

26 | 1155 | 846 | 50 | Keypress enter

28 | RUN ACTION |  |  |  | WAIT SECONDS | 2

29 | IF | PIXEL COLOR | Color [R=67, G=141, B=19]::At Location [X:385 Y:403] | IS THE SAME | GOTO MACRO LINE | 31

30 | RUN ACTION |  |  |  | GOTO MACRO LINE | 5

31 | 1863 | 840 | 50 | Left Click Down

32 | 1863 | 840 | 50 | Left Click Release

33 | IF | PIXEL COLOR | Color [R=4, G=17, B=46]::At Location [X:61 Y:1113] | IS NOT THE SAME | GOTO MACRO LINE | 35

34 | RUN ACTION |  |  |  | GOTO MACRO LINE | 33

35 | RUN ACTION |  |  |  | WAIT SECONDS | 2

36 | 1754 | 984 | 50 | Left Click Down

37 | 1754 | 984 | 50 | Left Click Release

38 | 1754 | 984 | 50 | Keypress backspace

39 | RUN ACTION |  |  |  | COPY TO CLIPBOARD | %INTEGER1%

40 | RUN ACTION |  |  |  | PASTE FROM CLIPBOARD

41 | 1759 | 1082 | 50 | Left Click Down

42 | 1759 | 1082 | 50 | Left Click Release

43 | 1759 | 1082 | 50 | Keypress backspace

44 | RUN ACTION |  |  |  | COPY TO CLIPBOARD | %INTEGER2%

45 | RUN ACTION |  |  |  | PASTE FROM CLIPBOARD

46 | 717 | 16 | 50 | Keypress tab

47 | 717 | 16 | 50 | Keypress tab

48 | 1854 | 1238 | 50 | Left Click Down

49 | 1854 | 1238 | 50 | Left Click Release

50 | RUN ACTION |  |  |  | WAIT SECONDS | 1

51 | RUN ACTION |  |  |  | DEFINE INTEGER VARIABLE | %INTEGER3%::-1

52 | IF | INTEGER VARIABLE | %INTEGER3% | = | 0 | STOP

53 | RUN ACTION |  |  |  | GOTO MACRO LINE | 5



[Steve]

Hi kampberg,

Cheers for the words on MMM and nice Macro BTW.

I think I might have found the issue. Check out the screen shot below of your macro and the event log:



The event log shows that the macro is 'short looping' every 230 milliseconds continuously through lines 21, 22, and 23 before I stop the macro manually at the end of the event log. This is because my desktop does not match the PIXEL color for conditions 21 and 22 however perhaps this is happening for you also.

A short loop like that running continuously will up your memory a little bit but shouldn't cause MMM to be 'forced closed'. Can you explain exactly what you mean by that? Do you have to 'hard kill' the process?

Also your line 18, WAIT SECONDS 0.5 is not waiting 500 milliseconds, it's skipping. 18 | RUN ACTION |  |  |  | WAIT SECONDS | 0.5

You need WAIT MILLISECONDS | 500 for this to work as expected. SECONDS does not except decimal values. 18 | RUN ACTION |  |  |  | WAIT  MILLISECONDS | 500

I suggest adding a WAIT after line 22 to delay the infinite loop or another condition to break out.

23 | RUN ACTION |  |  |  | WAIT SECONDS | 1

Hope this helps. Keep me posted.

Cheers,
Steve.

[kampberg]

Hi Steve,

My "force closed" means MMM stopped running and then closed itself. I have some 'short looping' to check whether the PIXEL COLOR for a webpage loading screen(grey screen) has ended so that I can immediately run the next action. I think it drained my memory. After added a WAIT for my condition checks, it runs better and longer now, however, it seems that I can't keep it running for a relatively long time like half an hour or more.

Before:

33 | IF | PIXEL COLOR | Color [R=4, G=17, B=46]::At Location [X:61 Y:1113] | IS NOT THE SAME | GOTO MACRO LINE | 35
34 | RUN ACTION |  |  |  | GOTO MACRO LINE | 33


Now:

33 | IF | PIXEL COLOR | Color [R=4, G=17, B=46]::At Location [X:61 Y:1113] | IS NOT THE SAME | GOTO MACRO LINE | 36
34 | RUN ACTION |  |  |  | WAIT MILLISECONDS | 100
35 | RUN ACTION |  |  |  | GOTO MACRO LINE | 33



Thanks for your help!

Cheers!
Kampberg

[kampberg]

Maybe the coming new feature - PIXEL COLOR detect will resolve my issue? (I'm excited!)

[Johnc]

I had a similar problem too at times but it went away after I rebooted the computer.

[Steve]

Oct 9, 2018 10:00:57 GMT kampberg said:

Maybe the coming new feature - PIXEL COLOR detect will resolve my issue? (I'm excited!)

There are some improvements and new features coming for PIXEL COLOR that will make this a lot easier. Update should be out very shortly, hopefully if all goes well I will be able to get it out by the end of the week.

[Steve]

Oct 9, 2018 20:34:59 GMT Steve said:

Oct 9, 2018 10:00:57 GMT kampberg said:

Maybe the coming new feature - PIXEL COLOR detect will resolve my issue? (I'm excited!)

There are some improvements and new features coming for PIXEL COLOR that will make this a lot easier. Update should be out very shortly, hopefully if all goes well I will be able to get it out by the end of the week.

Update dropped today - check out www.turnssoft.com/conditions.html#pixelcolor for the new features